add handler for exec local command#116
add handler for exec local command#116missedone wants to merge 4 commits intovmware-archive:masterfrom
Conversation
| handleEvent(s, newObj, "updated") | ||
| } | ||
|
|
||
| func handleEvent(s *Exec, obj interface{}, action string) { |
There was a problem hiding this comment.
add handler for running local command when receiving events
|
Hi @missedone. |
There was a problem hiding this comment.
Would you provide some content to the README file explaining the use case and an example of your commit?
Looks like you're also adding support for configmaps, right? That seems to be managed by another PR, so it's better to decouple PRs between them.
Thanks for your time!
|
@jbianquetti-nami , example added: 369bdcf |
missedone
force-pushed
the
feat/handler_exec
branch
from
369bdcf to
3fe9e5d
Compare
|
just rebased the PR, please review again, thx |
|
I think it's a nice feature to have but needs some care. Can you fix conflicts? |
|
sure, will resolve the conflicts. |
# Conflicts: # README.md # cmd/config.go # config/config.go # pkg/client/run.go # pkg/handlers/handler.go
|
conflicts resolved |
| limitations under the License. | ||
| */ | ||
|
|
||
| package exec |
There was a problem hiding this comment.
Putting my end user's hat on, I'd love to read some more documentation about what problems does the handler implemented in this package address and some instructions about how to use it.
(A package level comment seems to be a good place to put such doc)
3 participants
No description provided.