test: add batch image generation tests #152
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update mock ImagePredictions.generate() to return pending status for batch=True - Add test_image_generate_batch_with_file - Add test_image_generate_batch_with_url - Add test_image_generate_batch_with_multiple_images - Add test_image_generate_batch_with_pil_images - Add test_image_generate_non_batch_still_works - Add test_image_generate_batch_then_wait (batch + polling) Co-Authored-By: Sudeep Pillai <sudeep.pillai@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds 6 tests for
batch=Truesupport in image generation, complementing the backend changes in vlm-lab#1586. Updates the mockImagePredictions.generate()to returnstatus="pending"whenbatch=Trueis passed (matching the real API behavior), and adds test cases covering file paths, URLs, multiple images, PIL objects, explicitbatch=False, and the batch→wait polling flow.Review & Testing Checklist for Human
batch=True→ pending response) but do not exercise the realImagePredictions.generate()invlmrun/client/predictions.py. Consider whether an integration test against the live API (after vlm-lab#1586 is deployed) is needed to verify the full round-trip.test_image_generate_batch_then_wait: The mock'sPrediction.wait()always returnscompletedimmediately — it doesn't simulate a pending→completed transition. Verify this is acceptable or if a more realistic mock (e.g., returning pending on first call, completed on second) would be more valuable.make testlocally to confirm all 224 tests pass (6 new + 218 existing).Notes
blackformatting failure onvlmrun/cli/_cli/chat.pyis unrelated to these changes.