Skip to content

Conversation

@sjmonson
Copy link
Collaborator

Summary

Splits the RequestFormatter into multiple separate components across data loading, data preprocessing, and the backend. Necessary step for next attempt at multi-turn.

Details

  • Removed the RequestFormatter preprocessor
  • Added "Encode" preprocessors for audio, video, and image
  • Added a "Finalizer" stage after preprocessors to convert from column ordered data to request object
  • Added most of previous formatter code to backend

Test Plan

  • Run all know benchmark well-lit pathways

Related Issues

  • Resolves #

  • "I certify that all code in this PR is my own, except as noted below."

Use of AI

  • Includes AI-assisted code completion
  • Includes code generated by an AI application
  • Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes ## WRITTEN BY AI ##)

@sjmonson sjmonson force-pushed the feat/split_formatter branch from 1e80237 to 687f702 Compare November 21, 2025 23:11
@sjmonson sjmonson force-pushed the feat/split_formatter branch from 8dbc7f5 to cef2e60 Compare December 9, 2025 18:23
@sjmonson sjmonson mentioned this pull request Dec 15, 2025
26 tasks
@sjmonson sjmonson force-pushed the feat/split_formatter branch from 7a9444c to ce7798c Compare January 19, 2026 19:29
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
@sjmonson sjmonson force-pushed the feat/split_formatter branch from c98234b to 28ece45 Compare January 26, 2026 16:43
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
@sjmonson
Copy link
Collaborator Author

sjmonson commented Jan 26, 2026

A note on --request-type: Request type only really makes sense in the context of the openai_http backend. For upcoming backends (such as #178 and #548) I imagine request_type will be completely ignored. Ideally we would not give openai_http any special treatment and require request_type to either be specified as a --backend-kwarg (basically how its implemented now without the special --request-type shorthand) or as entirely separate backend for each request-type. For now I have kept --request-type to avoid user confusion.

Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants