-
Notifications
You must be signed in to change notification settings - Fork 224
Issue-1973 - docs(whatisvitess): update What Is Vitess overview for clarity and detail ([#1973]) #2007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marcschaeferger
wants to merge
1
commit into
vitessio:prod
Choose a base branch
from
marcschaeferger:Issue-1973
base: prod
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+148
−104
Open
Issue-1973 - docs(whatisvitess): update What Is Vitess overview for clarity and detail ([#1973]) #2007
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did this text come from? The only key part that I don't like is this:
VTTablets manage a MySQL database instance but they are not "database instances".
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to close this in the coming weeks if I don't hear back from you @marcschaeferger .
We've had to deal with a lot of "drive-by" PRs from AI and if I don't hear back then I will assume this was another one. I apologize if that assessment is a mistake, but I have questions about this PR and would like to make some changes and if I don't hear back from you after another week or two then I'll close it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattlord thanks and sorry for the late reply.
You're right about the VTTablets sentence, that sentence was my own wording (partially) (probably in german) and not copied from elsewhere. I wrote the documentation in "my englisch + german mix" and then gave it to an AI for translation and mostly wording/grammar improvments as i'm not a native english speaker and i wanted to balance that with AI. So totally my fault, for not checking the AI output thoroughly enough, will not happen again, as this + a few other PR's on this and other projects were like quick-shots and my first ones beside heavy company Git (DevOps) work (and first on Github for me).
This is in my option and wasn’t meant as a “drive-by” AI PR. I do this in my free time, as i want to start contributing to CNCF projects and in the last days I was busy with other projects but mostly private stuff and my fulltime job itself. I saw your first comment shortly after you posted it, but then didn’t get back to it and simply forgot.
I do state the use of AI in my work if it's used, like i did with the Summary by Copilot. I'll update the PR description with that information and that i used additonaly AI for translation and grammarc/wording improvments.
I’m happy to take your suggestion, if you have something else.