Skip to content

chore: Deploy fix - base href updated for local and live #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhushan-ebi merged 2 commits into from
Sep 15, 2025
Merged

chore: Deploy fix - base href updated for local and live #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
135cc80
chore: Deploy fix - base href updated for local and live
bhushan-ebi Sep 15, 2025
c3a626d
chore: Deploy fix - Build command updated
bhushan-ebi Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
- name: Install Dependencies
run: npm install
- name: Build
run: npm run build
run: npm run build:ghpages
- name: Upload Build Artifacts
uses: actions/upload-artifact@v4
with:
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
"scripts": {
"ng": "ng",
"start": "ng serve",
"build": "ng build --configuration production",
"build": "ng build",
"build:ghpages": "ng build --configuration production --base-href /vf-angular/",
"build:dev": "ng build --configuration development",
"watch": "ng build --watch --configuration development",
"test": "ng test",
Expand Down
135 changes: 0 additions & 135 deletions src/app/components/footer/footer.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,135 +0,0 @@
.footer {
background: #2d2d2d;
color: white;
padding: 4rem 2rem 2rem;

.footer-content {
max-width: 1200px;
margin: 0 auto;
display: grid;
grid-template-columns: 1.5fr 2fr;
gap: 4rem;
margin-bottom: 3rem;

.footer-brand {
.logo {
display: flex;
align-items: center;
gap: 0.5rem;
margin-bottom: 1rem;

img {
height: 32px;
}

span {
font-size: 1.25rem;
font-weight: 500;
}
}

.description {
color: #a0a0a0;
line-height: 1.6;
margin: 0;
}
}

.footer-links {
display: grid;
grid-template-columns: repeat(3, 1fr);
gap: 2rem;

.link-group {
h3 {
color: white;
font-size: 1rem;
margin: 0 0 1rem;
text-transform: uppercase;
letter-spacing: 0.05em;
}

ul {
list-style: none;
padding: 0;
margin: 0;

li {
margin-bottom: 0.5rem;

a {
color: #a0a0a0;
text-decoration: none;
transition: color 0.2s;

&:hover {
color: white;
}
}
}
}
}
}
}

.footer-bottom {
max-width: 1200px;
margin: 0 auto;
padding-top: 2rem;
border-top: 1px solid rgba(255,255,255,0.1);
display: flex;
justify-content: space-between;
align-items: center;

p {
color: #a0a0a0;
margin: 0;
}

.legal-links {
display: flex;
gap: 1.5rem;

a {
color: #a0a0a0;
text-decoration: none;
transition: color 0.2s;

&:hover {
color: white;
}
}
}
}
}

@media (max-width: 968px) {
.footer {
.footer-content {
grid-template-columns: 1fr;
gap: 2rem;

.footer-links {
grid-template-columns: repeat(2, 1fr);
}
}
}
}

@media (max-width: 576px) {
.footer {
padding: 2rem 1rem;

.footer-content {
.footer-links {
grid-template-columns: 1fr;
}
}

.footer-bottom {
flex-direction: column;
text-align: center;
gap: 1rem;
}
}
}
45 changes: 0 additions & 45 deletions src/app/components/header/header.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,45 +0,0 @@
.header {
display: flex;
justify-content: space-between;
align-items: center;
padding: 1rem 2rem;
background: white;
border-bottom: 1px solid #eee;

.logo {
display: flex;
align-items: center;
gap: 0.5rem;
font-weight: 500;

img {
height: 32px;
}
}

nav {
ul {
display: flex;
gap: 2rem;
list-style: none;
margin: 0;
padding: 0;

a {
color: #333;
text-decoration: none;
display: flex;
align-items: center;
gap: 0.25rem;

.dropdown-arrow {
font-size: 0.8em;
}

&:hover {
color: #006F3C;
}
}
}
}
}
2 changes: 1 addition & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<base href="/vf-angular/">
<base href="/">
<link rel="stylesheet" media="all" href="https://dev.assets.emblstatic.net/vf/develop/css/styles.css"/>
<!--
Want to build a site with the Visual Framework?
Expand Down