NSDK-293 Added async Task cancellation to fix concurrency crash #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
| /// Note: No lock needed - protected by task cancellation in Virtusize.load() | ||
| internal var serverStoreProductSet: Set<VirtusizeServerProduct> = [] |
Contributor
There was a problem hiding this comment.
Can what is the value if failure? can we also declare this as weak link?
Contributor
Author
There was a problem hiding this comment.
@michellequibido-virtusize VirtusizeRepository.swift is a singleton, so all properties live inside during whole app lifecycle. No need to add weak for memory management.
What about value if failure it depends. Every time a product is loaded, it will be placed to serverStoreProductSet, so either it will be empty or the product will be pre-cached by the previous request.
michellequibido-virtusize
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Related Links
⬅️ As Is
Multiple concurent thread Task for
load(product:)cause crash➡️ To Be
Implemented async Task cancellation to resolve a crash caused by concurrent task execution
☑️ Checklist
printetc are removedproduction