SDK version and SDK platform parameters to VirtusizeParams #195
Conversation
ObranS
changed the title
|
@ObranS please rebase trunk branch on main before merging the PR. |
devAbhimanyu
left a comment
devAbhimanyu
left a comment
There was a problem hiding this comment.
@ObranS are the versions up to date?
Yes it is |
* trunk: Increment build version Increment build version Fix: bra body measurements - suggested size issue fixed Increment build version Fixed LINE redirect url issue for WebView Codefixes based on pull request review comments Increment build version Fix (memory): resolve WebView leak, cleanup observers/listeners, fix initialization race condition Remove unused print() Update SDK version Fix: Added close button on error loading webview # Conflicts: # CHANGES.md # README-JP.md # README.md # Virtusize.podspec # Virtusize/Sources/VirtusizeConfiguration.swift # Virtusize/Tests/APIEventTests.swift # VirtusizeAuth.podspec # VirtusizeCore.podspec
There was a problem hiding this comment.
@ObranS thanks, @riicodespretty we need to check if these parameters are shared to the frontend
| static let allowedLanguages = "allowedLanguages" | ||
| static let detailsPanelCards = "detailsPanelCards" | ||
| static let sdkVersion = "sdkVersion" | ||
| static let sdkPlatform = "sdkPlatform" |
There was a problem hiding this comment.
https://app.clickup.com/t/3702259/NSDK-315
"sdkVersion": "1.2.3",
"sdkPlatform": "ios"
These parameters are injected into the WebUI. See VirtusizeWebViewController, line 290.
Afterwards, these parameters are represented in the WebView. They are used in the Flutter version to determine whether the platform is iOS or Android for diagnostic purposes.
|
@ObranS looks good to me. Just an observation, there are unrelated commits for this feature branch which is probably due to merging the trunk branch to this feature branch, may I suggest to use rebase instead of merge next time. And I think the feature branch name number should be 315 not 316? |
* trunk: Hotfix: fixed release.yaml to push release version Increment build version Increment build version - Fix: Added concurrent queue lock to fix race condition crashes - Fix: Add null safety and defensive programming # Conflicts: # CHANGES.md # README-JP.md # README.md # Virtusize.podspec # Virtusize/Sources/VirtusizeConfiguration.swift # Virtusize/Tests/APIEventTests.swift # VirtusizeAuth.podspec # VirtusizeCore.podspec
ObranS
force-pushed
the
feature/NSDK-316-sdk-parameters
branch
from
818370e to
d0393e2
Compare
* trunk: [NSDK-363]Add optional configuration for show/hide privacy policy in inpage standard - Fix: fixed VirtusizeOrder API key parameter
🔗 Related Links
⬅️ As Is
There is no way to see the SDK platforms and the Flutter versions
➡️ To Be
Added parameters to VirtusizeParams:
{
"sdkVersion" : "1.2.3",
"sdkPlatform" : "ios",
}
☑️ Checklist
printetc are removedproduction