Skip to content

Conversation

@ObranS
Copy link
Contributor

@ObranS ObranS commented Jan 15, 2026

🔗 Related Links

⬅️ As Is

Get recommended size API error response

➡️ To Be

Fixed request payload

☑️ Checklist

  • Useless comments and/or Log.d etc are removed
  • Unit test are covered
  • Code has been deployed and tested on STG
  • ClickUp ticket status has been updated to production
  • Update CHANGELOG.md with the new changes

Copy link

@devAbhimanyu devAbhimanyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

val braSizeMap = JsonUtils.jsonObjectToMap(braSizeJsonObject)
braSize = if (braSizeMap.isEmpty()) null else braSizeMap
}
if (age == 0 || height == 0 || weight.isBlank() || bodyData.isEmpty()) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be a safe guard?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devAbhimanyu I do not see this code on iOS SDK + This parameters are optional (for SHOE those are missing).

devAbhimanyu

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants