[improve][pulsar-testclient] Add disableBatching as CLI argument for pulsar-perf-producer #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhabalia
reviewed
Aug 31, 2022
|
|
||
| @Parameter(names = { "-db", | ||
| "--disable-batching" }, description = "Disable batching if true") | ||
| public boolean disableBatching = false; |
There was a problem hiding this comment.
default value is false. you don't need extra assignment for boolean.
| } | ||
| }); | ||
|
|
||
| Consumer<byte[]> newConsumer1 = pulsarClient.newConsumer().topic(topic).subscriptionName("sub-2") |
There was a problem hiding this comment.
we don't have to publish or consume message. somehow, we need to assert that Producer is created with batching-disable option. you can also use reflection if any variable is private and you have to find the value of that field.
|
The pr had no activity for 30 days, mark with Stale label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The pulsar-perf-tool should be able to take "disableBatching" as an input argument as it can be provided by the user.
Modifications
Add an extra parameter to in the PerformanceProducer.java class.
Extract producerBuilder creation into a separate method.
Add unit testcase to verify if batching is disabled
Verifying this change
This change added tests and can be verified as follows:
-Added unit test to verify functionality with batching disabled
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)