Open
Conversation
Author
|
Author
|
no compression, have to do mcap recover (due to padding, only at last) |
chengguizi
commented
Aug 5, 2025
| // FileWriter /////////////////////////////////////////////////////////////////// | ||
| #ifdef ALIGNED_WRITE | ||
| constexpr size_t BUFFER_SIZE = 140 * 1024 * 1024; | ||
| constexpr size_t IORING_BUFF_SIZE = 100 * 1024 * 1024; |
Author
There was a problem hiding this comment.
submit constant size, currently 100MB
chengguizi
commented
Aug 5, 2025
| std::cerr << "io_uring_get_sqe failed\n"; | ||
| return false; | ||
| } | ||
| io_uring_prep_write(sqe, 0, buf,IORING_BUFF_SIZE, offset); |
Author
There was a problem hiding this comment.
io_uring_prep_write
io_uring_prep_write_fixed - by right should be zero copy. but we have speed issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.