Add support for a subset of SVG elements #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables us to embed SVG graphics in HTML documents.
sorcix
changed the title
Owner
|
ah, thank you for this!! i meant to create two issues for myself for adding just a couple things: a new feature probably isn't needed for this, it doesn't add any new dependencies or add a gigantic amount of code. it's probably fine to just be included in the library like everything else is. would it possible for you to add a bit of documentation to elements/inherent attributes? i'm attempting to keep this crate 100% documented, otherwise this pr looks fantastic. thanks a lot!! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking into
hypertextas a replacement formaud.My templates include a lot of inline SVG icons. This branch is an attempt to make it work in
hypertext. It does!Just creating this PR to let you know it works. If you're open to adding SVG support to
hypertext, let me know. I'm still figuring out if migrating tohypertextis actually a good idea. :-)closes #2