GetOrFetch: Don't attempt unwrap if err != nil #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi @ernstwi , I did a quick test and can confirm that this is an issue. However, I think the fix for this is going to be a little more complex. I'll try to find some time for this soon! |
Author
|
OK, thanks! Let me know if I can help, otherwise I'll leave it to you then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: If
fetchFnreturns an error, we still attempt an unwrap andErrInvalidTypeis (most likely) returned here. The original error is not logged, which causes problems in observability.Proposed solution: Don't attempt to unwrap if
fetchFnreturns an error, instead return that error immediately.Alternative solution: Another option could be to still attempt the unwrap, but do an
errors.Joinwith the original error like in #33 if the type assertion fails. But I don't think this makes as much sense.Not tested yet, but opening a PR to see what you think. Maybe there are some tests which should also be updated?