[RSDK-10599] Add full keras support to tf-cpu #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penguinland
reviewed
Aug 1, 2025
Contributor
penguinland
left a comment
penguinland
left a comment
There was a problem hiding this comment.
LPlausibleTM! but I defer to Khari, who knows this way better than I do.
AGanguly13
force-pushed
the
keras-support
branch
from
3f397c5 to
7718c80
Compare
penguinland
reviewed
Aug 6, 2025
Contributor
penguinland
left a comment
penguinland
left a comment
There was a problem hiding this comment.
This still looks good to me, but I still defer to Khari's expertise
bhaney
requested changes
Aug 11, 2025
Contributor
bhaney
left a comment
bhaney
left a comment
There was a problem hiding this comment.
Some changes, mostly about defining the input and output tensors. Also:
- have you tested this on windows?
- release an -rc version from this branch, and find a .keras file from here and try it out to see it it loads properly. https://www.kaggle.com/models?framework=keras
- using the python SDK, create a random input and see if the infer works as intended
AGanguly13
force-pushed
the
keras-support
branch
from
361786c to
fbf770c
Compare
Contributor
|
Will close this for now as we revisit Keras support for the version of tf that is used in training |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR, just need eyes on it for now, still have to test on app.viam.com
Main logic in commit titled "logic changes for keras support"