Skip to content

Conversation

@HipsterBrown
Copy link
Contributor

The README documents a field called enable_i2c under the board_settings config for the Raspberry Pi board modules. The code was actually using turn_i2c_on. Rather than updating the README, I chose to update the code to use the better name.

Copy link
Contributor

@IanWhalen IanWhalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from an interface perspective. Have to leave it to John or someone else to approve the code.

@johnwalicki
Copy link
Collaborator

I reviewed the code - LGTM

Copy link
Collaborator

@johnwalicki johnwalicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HipsterBrown HipsterBrown merged commit d579d5e into viam-modules:main Dec 16, 2025
2 checks passed
@HipsterBrown HipsterBrown deleted the nhehr/enable-i2c branch December 16, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants