Open
Conversation
… filter Three fixes to augref interval computation: 1. Fix crash in try_extend_backward when backward walk reaches the start of a path. get_next_step(path_front_end) is invalid in bdsg; return path_begin directly instead. 2. Add cross-path interval merging in add_interval. When a new interval is adjacent to an existing interval on a different path, attempt to extend one interval to absorb the other if they share the same node sequence. This reduces augref fragmentation. 3. Defer minimum length filter to after all merging is complete. Previously short intervals were discarded in compute_snarl and fill_uncovered_nodes before add_interval could merge them with adjacent intervals. Now all intervals are kept during computation (min_length=1) and filtered by the new filter_short_intervals() after defragment_intervals(). Also adds rank_by_name option (hardcoded true for testing) to rank traversal fragments by path name instead of coverage, and adds verbose output showing the post-filter interval count. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a few mistakes:
This PR fixes all issues, but reverts back to using lexicographic rather than highest coverage traversals in order to get around the determinism concerns (and, in hindsight, is why I was using it in the previous deconstruct-based version). There's a fix for that but I'll worry about it in another PR ...