Fix cycle detection in fill_uncovered_nodes second pass#4828
Merged
glennhickey merged 1 commit intomasterfrom Feb 13, 2026
Merged
Fix cycle detection in fill_uncovered_nodes second pass#4828glennhickey merged 1 commit intomasterfrom
glennhickey merged 1 commit intomasterfrom
Conversation
The second pass that covers nodes outside snarls had no cycle check, so paths that visit a node twice could produce cyclic intervals. With high --min-augref-len values, more nodes are left for this pass, making cycles more likely. Fix by tracking nodes per interval and breaking at duplicates, starting a new interval at the repeated node (matching the get_uncovered_intervals logic in the first pass). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting high values for
vg paths --min-augref-lencould trigger a bug that would create a cycle in the augmented coordinates, which would then be caught during a validations and abort. This PR should fix this case.