Open
Conversation
kopax
reviewed
Mar 24, 2024
kopax
left a comment
kopax
left a comment
There was a problem hiding this comment.
This diff is not readable, there is everything reformated, is it possible to revert, and edit with vim so you don't get any reformat and we can see the lines that fixe ?
Author
|
oh sorry, I messed up there a bit. somehow managed to make CRLF out of LF. Anyway, done now. There is only 1 commit now without format change. |
Owner
|
Sorry I've been really lazy with this whole project. But this is something I cannot verify to work but you have tried this in real life use? The code looks correct though. |
Author
|
Yes, I am actually using it already with the Requarks/Wiki (requarks/wiki#3599) and it works fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#65