Skip to content

Conversation

@bratseth
Copy link
Member

This will require more work, but I just want to get a run through with the config builder API stuff.

@bratseth bratseth requested a review from hmusum January 22, 2026 13:51
Copy link
Member

@hmusum hmusum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be something wrong with parentheses, but I can't see exactly where right now.

hmusum
hmusum previously approved these changes Jan 22, 2026
documentapi(ContainerDocumentApi.new)).
sd(selfdir + 'lucene.sd'))
start
feed_and_wait_for_docs("lucene", 1, :file => selfdir + "document.json")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
feed_and_wait_for_docs("lucene", 3, :file => selfdir + "document.json")

config(ConfigOverride.new('com.yahoo.language.lucene.lucene-analysis').
add(MapConfig.new('analysis').
add('profile=specialTokens',
ConfigValue.new().
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like ConfigValue constructor takes 2 arguments?

@bratseth bratseth merged commit 4ac424e into master Jan 22, 2026
2 checks passed
@bratseth bratseth deleted the bratseth/linguistic-profiles branch January 22, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants