Turbopack: Various cleanup for turbo-tasks-fs, mostly retry logic and string formatting #88668

bgw · 2026-01-16T21:39:04Z

Turbopack: avoid blocking tasks for I/O work #87661 removed the tokio::task::spawn_blocking call from retry_blocking, so we can simplify things a lot by removing the Send + 'static bounds, and eliminate a bunch of cloning Paths into PathBufs.
retry_blocking no longer takes a path argument. After removing the path cloning requirements, it's now easier for callers to capture paths via a closure, and it's more flexible for IO operations that need to pass in more than a single path.
Adds retry_blocking_custom, which I use in Turbopack: Tweak retry loop for link creation to try to fix os error 80 on Windows #88669 that allows customizing what error kinds we retry on.
Adds documentation to retry_blocking explaining why we need this. It's often unclear to new people on the team why we have to retry filesystem operations (Windows, basically). This was unclear to me when I was new to this code, and other people have asked similar questions.
We shouldn't use Path::display for error messages or tracing spans. It's easier to use Debug, and Debug ensures that if the error is related to unicode, that information isn't lost in the error message.
More consistently apply tracing spans using .instrument.
Use the modern inline syntax for some format strings.
let foo = RcStr::from(bar) is preferred over let foo: RcStr = bar.into()

bgw · 2026-01-16T21:39:21Z

Turbopack: Tweak retry loop for link creation to try to fix os error 80 on Windows #88669
Turbopack: Various cleanup for turbo-tasks-fs, mostly retry logic and string formatting #88668 👈 (View in Graphite)
Turbopack: Add a stress test / fuzzer that tries creating many symlinks in a tight loop #88667
Turbopack: Move fuzzer for fs watcher into a separate file/module #88666
Turbopack: Add file write invalidation tracking to filesystem watcher fuzzing #88665
Turbopack: Extend filesystem watcher fuzzing to cover symlinks and junction points #88192
canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2026-01-16T22:02:41Z

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing bgw/fs-and-retry-cleanup (2554f63) with canary (aa8754c)}

Summary

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks¹

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

nextjs-bot · 2026-01-16T22:31:31Z

Stats from current PR

✅ No significant changes detected

📊 All Metrics

📖 Metrics Glossary

Dev Server Metrics:

Listen = TCP port starts accepting connections
First Request = HTTP server returns successful response
Cold = Fresh build (no cache)
Warm = With cached build artifacts

Build Metrics:

Fresh = Clean build (no .next directory)
Cached = With existing .next directory

Change Thresholds:

Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
Size: Changes < 1KB AND < 1% are insignificant
All other changes are flagged to catch regressions

⚡ Dev Server

Metric	Canary	PR	Change	Trend
Cold (Listen)	455ms	455ms	✓	▁▁▁▁█
Cold (Ready in log)	446ms	446ms	✓	▁▁▁▁█
Cold (First Request)	856ms	857ms	✓	▂▃▁▃█
Warm (Listen)	456ms	456ms	✓	▁▁▂▁█
Warm (Ready in log)	447ms	448ms	✓	▁▁▂▁█
Warm (First Request)	357ms	359ms	✓	▁▂▂▁█

📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric	Canary	PR	Change	Trend
Cold (Listen)	506ms	456ms	✓	▁▁▁▁█
Cold (Ready in log)	460ms	459ms	✓	▁▁▁▁█
Cold (First Request)	1.826s	1.820s	✓	▁▁▁▁█
Warm (Listen)	456ms	456ms	✓	▁▁▁▁█
Warm (Ready in log)	458ms	457ms	✓	▁▁▁▁█
Warm (First Request)	1.838s	1.833s	✓	▁▁▁▁█

⚡ Production Builds

Metric	Canary	PR	Change	Trend
Fresh Build	4.476s	4.391s	✓	▁▁▂▁█
Cached Build	4.471s	4.454s	✓	▁▁▁▁█

📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric	Canary	PR	Change	Trend
Fresh Build	14.471s	14.461s	✓	▂▅▃█▃
Cached Build	14.617s	14.650s	✓	▂▆▃█▇
node_modules Size	460 MB	460 MB	✓	█████

📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **432 kB** → **432 kB** ✅ -49 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware

	Canary	PR	Change
middleware-b..fest.js gzip	761 B	765 B	✓
Total	761 B	765 B	⚠️ +4 B

Build Details

Build Manifests

	Canary	PR	Change
_buildManifest.js gzip	449 B	449 B	✓
Total	449 B	449 B	✓

📦 Webpack

Client

Main Bundles

	Canary	PR	Change
2086.HASH.js gzip	169 B	N/A	-
2161-HASH.js gzip	5.41 kB	N/A	-
2747-HASH.js gzip	4.48 kB	N/A	-
4322-HASH.js gzip	52.7 kB	N/A	-
ec793fe8-HASH.js gzip	62.3 kB	N/A	-
framework-HASH.js gzip	59.8 kB	59.8 kB	✓
main-app-HASH.js gzip	252 B	253 B	✓
main-HASH.js gzip	38.7 kB	39.1 kB	✓
webpack-HASH.js gzip	1.68 kB	1.68 kB	✓
1596.HASH.js gzip	N/A	169 B	-
2658-HASH.js gzip	N/A	52.4 kB	-
6349-HASH.js gzip	N/A	4.46 kB	-
7019-HASH.js gzip	N/A	5.43 kB	-
b17a3386-HASH.js gzip	N/A	62.3 kB	-
Total	226 kB	226 kB	⚠️ +53 B

Polyfills

	Canary	PR	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Total	39.4 kB	39.4 kB	✓

Pages

	Canary	PR	Change
_app-HASH.js gzip	194 B	193 B	✓
_error-HASH.js gzip	182 B	182 B	✓
css-HASH.js gzip	336 B	335 B	✓
dynamic-HASH.js gzip	1.8 kB	1.8 kB	✓
edge-ssr-HASH.js gzip	256 B	256 B	✓
head-HASH.js gzip	352 B	349 B	✓
hooks-HASH.js gzip	385 B	384 B	✓
image-HASH.js gzip	580 B	580 B	✓
index-HASH.js gzip	259 B	258 B	✓
link-HASH.js gzip	2.5 kB	2.51 kB	✓
routerDirect..HASH.js gzip	319 B	317 B	✓
script-HASH.js gzip	385 B	387 B	✓
withRouter-HASH.js gzip	316 B	315 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Total	7.97 kB	7.96 kB	✅ -8 B

Server

Edge SSR

	Canary	PR	Change
edge-ssr.js gzip	125 kB	125 kB	✓
page.js gzip	243 kB	239 kB	🟢 4.85 kB (-2%)
Total	368 kB	363 kB	✅ -4.84 kB

Middleware

	Canary	PR	Change
middleware-b..fest.js gzip	617 B	619 B	✓
middleware-r..fest.js gzip	155 B	156 B	✓
middleware.js gzip	33.1 kB	33.3 kB	✓
edge-runtime..pack.js gzip	842 B	842 B	✓
Total	34.7 kB	34.9 kB	⚠️ +190 B

Build Details

Build Manifests

	Canary	PR	Change
_buildManifest.js gzip	738 B	738 B	✓
Total	738 B	738 B	✓

Build Cache

	Canary	PR	Change
0.pack gzip	3.69 MB	3.69 MB	🔴 +4.54 kB (+0%)
index.pack gzip	101 kB	99.3 kB	🟢 1.57 kB (-2%)
index.pack.old gzip	101 kB	101 kB	✓
Total	3.89 MB	3.89 MB	⚠️ +3.06 kB

🔄 Shared (bundler-independent)

Runtimes

	Canary	PR	Change
app-page-exp...dev.js gzip	305 kB	305 kB	✓
app-page-exp..prod.js gzip	162 kB	162 kB	✓
app-page-tur...dev.js gzip	305 kB	305 kB	✓
app-page-tur..prod.js gzip	162 kB	162 kB	✓
app-page-tur...dev.js gzip	302 kB	302 kB	✓
app-page-tur..prod.js gzip	160 kB	160 kB	✓
app-page.run...dev.js gzip	302 kB	302 kB	✓
app-page.run..prod.js gzip	160 kB	160 kB	✓
app-route-ex...dev.js gzip	68.8 kB	68.8 kB	✓
app-route-ex..prod.js gzip	47.6 kB	47.6 kB	✓
app-route-tu...dev.js gzip	68.8 kB	68.8 kB	✓
app-route-tu..prod.js gzip	47.6 kB	47.6 kB	✓
app-route-tu...dev.js gzip	68.4 kB	68.4 kB	✓
app-route-tu..prod.js gzip	47.4 kB	47.4 kB	✓
app-route.ru...dev.js gzip	68.4 kB	68.4 kB	✓
app-route.ru..prod.js gzip	47.4 kB	47.4 kB	✓
dist_client_...dev.js gzip	324 B	324 B	✓
dist_client_...dev.js gzip	326 B	326 B	✓
dist_client_...dev.js gzip	318 B	318 B	✓
dist_client_...dev.js gzip	317 B	317 B	✓
pages-api-tu...dev.js gzip	41.2 kB	41.2 kB	✓
pages-api-tu..prod.js gzip	31.3 kB	31.3 kB	✓
pages-api.ru...dev.js gzip	41.1 kB	41.1 kB	✓
pages-api.ru..prod.js gzip	31.2 kB	31.2 kB	✓
pages-turbo....dev.js gzip	50.8 kB	50.8 kB	✓
pages-turbo...prod.js gzip	38.2 kB	38.2 kB	✓
pages.runtim...dev.js gzip	50.8 kB	50.8 kB	✓
pages.runtim..prod.js gzip	38.2 kB	38.2 kB	✓
server.runti..prod.js gzip	62.2 kB	62.2 kB	✓
Total	2.71 MB	2.71 MB	✅ -1 B

turbopack/crates/turbo-tasks-fs/src/lib.rs

… string formatting

…g()]'

nextjs-bot · 2026-01-21T23:35:23Z

Tests Passed

bgw · 2026-01-22T00:43:22Z

Merge activity

Jan 22, 12:43 AM UTC: @bgw merged this pull request with Graphite.

nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 16, 2026

This was referenced Jan 16, 2026

Turbopack: Add a stress test / fuzzer that tries creating many symlinks in a tight loop #88667

Merged

Turbopack: Tweak retry loop for link creation to try to fix os error 80 on Windows #88669

Merged

bgw force-pushed the bgw/fs-and-retry-cleanup branch from 823a5c3 to 8964035 Compare January 16, 2026 22:09

bgw requested a review from a team January 16, 2026 22:31

bgw marked this pull request as ready for review January 16, 2026 22:41

lukesandberg approved these changes Jan 19, 2026

View reviewed changes

turbopack/crates/turbo-tasks-fs/src/lib.rs Outdated Show resolved Hide resolved

bgw force-pushed the bgw/symlink-stress branch from e02a9ba to ee8dc1e Compare January 21, 2026 18:10

bgw force-pushed the bgw/fs-and-retry-cleanup branch from 8964035 to 17902e9 Compare January 21, 2026 18:10

bgw force-pushed the bgw/symlink-stress branch 2 times, most recently from d71635f to b84ae7d Compare January 21, 2026 18:42

bgw force-pushed the bgw/fs-and-retry-cleanup branch from 17902e9 to 40bb0f1 Compare January 21, 2026 18:42

bgw changed the base branch from bgw/symlink-stress to graphite-base/88668 January 21, 2026 21:04

bgw force-pushed the bgw/fs-and-retry-cleanup branch from 40bb0f1 to b302330 Compare January 21, 2026 21:04

bgw force-pushed the graphite-base/88668 branch from b84ae7d to 917ff14 Compare January 21, 2026 21:04

graphite-app bot changed the base branch from graphite-base/88668 to canary January 21, 2026 21:05

Turbopack: Various cleanup for turbo-tasks-fs, mostly retry logic and…

8e9c123

… string formatting

bgw force-pushed the bgw/fs-and-retry-cleanup branch from b302330 to 8e9c123 Compare January 21, 2026 21:05

switch validate_path_length_inner to use 'if cfg!()' instead of '#[cf…

2554f63

…g()]'

bgw merged commit f263c56 into canary Jan 22, 2026
288 of 295 checks passed

bgw deleted the bgw/fs-and-retry-cleanup branch January 22, 2026 00:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Turbopack: Various cleanup for turbo-tasks-fs, mostly retry logic and string formatting #88668

Turbopack: Various cleanup for turbo-tasks-fs, mostly retry logic and string formatting #88668

bgw commented Jan 16, 2026 •

edited

Loading

Uh oh!

bgw commented Jan 16, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Jan 16, 2026 •

edited

Loading

Uh oh!

nextjs-bot commented Jan 16, 2026 •

edited

Loading

⚡ Dev Server

📦 Dev Server (Webpack)

⚡ Production Builds

📦 Production Builds (Webpack)

Bundle Sizes

⚡ Turbopack

📦 Webpack

🔄 Shared (bundler-independent)

Uh oh!

Uh oh!

nextjs-bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

bgw commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Turbopack: Various cleanup for turbo-tasks-fs, mostly retry logic and string formatting #88668

Turbopack: Various cleanup for turbo-tasks-fs, mostly retry logic and string formatting #88668

Conversation

bgw commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bgw commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging this PR will not alter performance

Summary

Footnotes

Uh oh!

nextjs-bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Stats from current PR

✅ No significant changes detected

⚡ Dev Server

📦 Dev Server (Webpack)

⚡ Production Builds

📦 Production Builds (Webpack)

Bundle Sizes

⚡ Turbopack

📦 Webpack

🔄 Shared (bundler-independent)

Uh oh!

Uh oh!

nextjs-bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tests Passed

Uh oh!

Uh oh!

bgw commented Jan 22, 2026

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bgw commented Jan 16, 2026 •

edited

Loading

bgw commented Jan 16, 2026 •

edited

Loading

codspeed-hq bot commented Jan 16, 2026 •

edited

Loading

nextjs-bot commented Jan 16, 2026 •

edited

Loading

nextjs-bot commented Jan 21, 2026 •

edited

Loading