-
Notifications
You must be signed in to change notification settings - Fork 305
add --tsconfig-path option for CLI & support extends property in tsconfig.json
#914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
src/utils/load-tsconfig-options.js
Outdated
| * @param {ts.ModuleResolutionKind} moduleResolution | ||
| * @returns {string | undefined} | ||
| */ | ||
| function normalizeModuleResolutionOption(moduleResolution) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem very future proof.
Is there a way to have TypeScript convert this for us?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@styfle
I see.
I cloudn't find a way to get complete config objects by TypeScript, but I found tsconfck from microsoft/TypeScript#44573.
Does this library look future proof, do you think? If you think it's OK, I will rewrite src/utils/load-tsconfig-options.js.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d2b6b92 to
129d3df
Compare
129d3df to
5d85cd2
Compare
|
This is a great feature, thanks nokazn! 👏 |
|
Why is still on hold? Thanks for the PR |
|
Hello, when can we expect this to PR to be merged? |
|
Very interested in this addition. Is there anything I can do to help get this across the finish line? |
|
Hello, what's new about this? |
|
any update? |
|
Is there anything left to be done to get this PR merged? I don't mind helping out |
Overview
Hi, there!
I've made a PR to add a new CLI option and resolve potential problems. If there is something wrong or missing, feel free to point it out.
Thank you.
Changes
--tsconfig-pathto specify path totsconfig.jsonfile for CLI optiontsconfig.jsonis passed by this option, ncc sees that path directly, or if not, ncc resolve path totsconfig.jsonas beforeextendsproperty intsconfig.jsonuse officially provided API by TypeScript to resolve and parsecompilerOptions&extendspropertyadd param-case to convert values atjsxoption to kebab-casetsconfig.jsonoptions.Related