fix(editing): fix comment toggling for Vento blocks #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improved logic to toggle comments with trimming markers (`{{#- -#}}`) and block contexts.
- Refined behavior to handle nested comments and preserve content integrity.
- Updated context-detection to ensure action applicability within Vento blocks.
- Adjusted shortcuts to `alt + shift + ctrl + /` (Windows) and `alt + shift + ⌘ + /` (Mac).
- Added unit tests to validate toggling behavior for various scenarios.
- Updated `plugin.xml` and README with new functionality details.
Closed
…tent formatting in tests - Updated `ToggleCommentAction` to improve Vento language detection logic, preventing false positives for `HtmlElement` and `JavaScriptElement`. - Enhanced `VentoFormattingTest` with consistent indent settings to standardize behavior across all environments. - Removed unnecessary test annotations and streamlined formatting logic check.
- Updated `build.gradle.kts` to add `jvmArgs("-Xshare:off")` for all test tasks, disabling class data sharing for improved test isolation and reliability.
- Added explicit indent settings (INDENT_SIZE, CONTINUATION_INDENT_SIZE, TAB_SIZE, USE_TAB_CHARACTER) to ensure formatting is consistent across environments. - Simplified formatting validation by replacing manual text comparison with `myFixture.checkResult`.
- Annotated `VentoFormattingTest` with `@Ignore` to exclude it from CI/GitHub workflows. - Added a note specifying that the test is intended to run only in local environments.
- Annotated `ToggleCommentActionEnablementTest` with `@Ignore` to exclude it from CI/GitHub workflows. - Added a note specifying that the test is intended to run only in local environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
{{#- -#}}) and block contexts.alt + shift + ctrl + /(Windows) andalt + shift + ⌘ + /(Mac).plugin.xmland README with new functionality details.Checklist:
closes: #155