Skip to content

Comments

Install UI deps for Deno Deploy build#15

Closed
venikman wants to merge 1 commit intomainfrom
fix-ui-build-output
Closed

Install UI deps for Deno Deploy build#15
venikman wants to merge 1 commit intomainfrom
fix-ui-build-output

Conversation

@venikman
Copy link
Owner

@venikman venikman commented Jan 15, 2026

Summary

  • install Node and UI dependencies before running deno task ui:build
  • cache npm dependencies for faster Deno Deploy builds

Testing

  • not run (workflow changes only)

Summary by CodeRabbit

  • Chores
    • Updated deployment workflows to ensure UI dependencies are properly installed during the deployment process, improving deployment reliability and consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

Copilot AI review requested due to automatic review settings January 15, 2026 14:10
@continue
Copy link

continue bot commented Jan 15, 2026

All Green - Keep your PRs mergeable

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts


Unsubscribe from All Green comments

@coderabbitai
Copy link

coderabbitai bot commented Jan 15, 2026

📝 Walkthrough

Walkthrough

Two GitHub Actions deployment workflows now include Node.js 20 setup and UI dependency installation steps before existing deployment logic. These additions enable npm-based build tooling in the CI/CD pipeline for the UI layer.

Changes

Cohort / File(s) Summary
Workflow Node Setup & Dependencies
.github/workflows/deploy-deno.yml, .github/workflows/deploy-staging.yml
Added Node.js 20 setup step with npm caching (cache-dependency-path: src/ui/package-lock.json) and Install UI dependencies step running npm ci in src/ui directory. Changes applied identically to both workflows.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Hops of joy through workflows bright,
Node and npm, now locked tight,
UI builds with cache so fast,
Dependencies installed, deploy at last!
Two workflows dance in harmony's way, 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding Node setup and npm dependency installation before Deno Deploy builds, which aligns with the modifications to both deployment workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.



📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f2c81b2 and 0802418.

📒 Files selected for processing (2)
  • .github/workflows/deploy-deno.yml
  • .github/workflows/deploy-staging.yml
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
Repo: venikman/PromptAgent PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-15T13:48:27.166Z
Learning: Deploy only through GitHub Actions pipelines; no manual production deploys allowed
🔇 Additional comments (2)
.github/workflows/deploy-deno.yml (1)

24-32: LGTM! Node setup and dependency installation are correctly configured.

The step ordering is correct, npm ci is the right choice for CI environments, and caching is properly configured with the lock file path. The deploy step already excludes src/ui/node_modules which prevents bloating the deployment artifact.

Minor style suggestion: consider using working-directory instead of cd for slightly cleaner YAML:

- name: Install UI dependencies
  working-directory: src/ui
  run: npm ci
.github/workflows/deploy-staging.yml (1)

24-32: LGTM! Consistent with production workflow.

The Node setup and UI dependency installation steps are identical to deploy-deno.yml, ensuring staging/production parity. This consistency reduces the risk of environment-specific build issues.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Node.js setup and npm dependency installation steps to the Deno Deploy workflows to ensure UI dependencies are available before building the frontend assets.

Changes:

  • Added Node.js v20 setup with npm caching to both deploy workflows
  • Added step to install UI dependencies via npm ci before the UI build task

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/deploy-staging.yml Added Node setup and UI dependency installation for staging deployments
.github/workflows/deploy-deno.yml Added Node setup and UI dependency installation for production deployments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@venikman
Copy link
Owner Author

Superseded by #18

@venikman venikman closed this Jan 15, 2026
@venikman venikman deleted the fix-ui-build-output branch January 15, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant