This repository was archived by the owner on Dec 8, 2020. It is now read-only.
Adds to_event support for arbitrary structs#351
Open
jmnsf wants to merge 1 commit intovectordotdev:masterfrom
Open
Adds to_event support for arbitrary structs#351jmnsf wants to merge 1 commit intovectordotdev:masterfrom
to_event support for arbitrary structs#351jmnsf wants to merge 1 commit intovectordotdev:masterfrom
Conversation
Pull Request Test Coverage Report for Build 915
💛 - Coveralls |
Signed-off-by: João Ferreira <jmnsferreira@gmail.com>
ea111ce to
ea788b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to send structs as events in log metadata:
Right now, doing this raises an exception and the log message is dropped:
Use case
I'm using struct events in my project to represent something happening in the app and its associated data. In the event handler for those events, I'm adding the event itself as context to all logging. It doesn't work though, because Timber can't convert it.
This PR uses the struct name as the context namespace for its logged contents.