Skip to content

Conversation

@darrenvechain
Copy link
Member

@darrenvechain darrenvechain commented Dec 9, 2025

Description

Add unit tests for convert range function in logs endpoints

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@darrenvechain darrenvechain requested a review from a team as a code owner December 9, 2025 14:11
@darrenvechain darrenvechain marked this pull request as draft December 9, 2025 14:11
expected: nil,
},
{
name: "empty object returns full block range",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should null and {} output the same response?

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@darrenvechain darrenvechain marked this pull request as ready for review December 15, 2025 11:07
@darrenvechain darrenvechain changed the base branch from release/v2.4.1-old to release/v2.4.1 January 5, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants