Skip to content
This repository was archived by the owner on Feb 17, 2025. It is now read-only.

Conversation

@Agilulfo1820
Copy link
Member

@Agilulfo1820 Agilulfo1820 commented Dec 11, 2023

by using ethers v6 we need to replace any instance of .address with .getAddress() and .deployed with .waitForDeployment()

@freemanzMrojo freemanzMrojo self-requested a review January 4, 2024 15:28
Copy link
Member

@freemanzMrojo freemanzMrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Agilulfo1820 ,

This PR is failing in the build because we are deleting the package-lock.json in the GH action.

Since updating packages is not part of this PR, could you remove that line? (on top of that, I do not think we should be deleting the lock file in the build). That should fix the issue, will approve after that.

Thanks.

@Agilulfo1820
Copy link
Member Author

Hi @Agilulfo1820 ,

This PR is failing in the build because we are deleting the package-lock.json in the GH action.

Since updating packages is not part of this PR, could you remove that line? (on top of that, I do not think we should be deleting the lock file in the build). That should fix the issue, will approve after that.

Thanks.

Are you referring to the process.exit() line?

@freemanzMrojo
Copy link
Member

freemanzMrojo commented Jan 4, 2024

Hi @Agilulfo1820 ,
This PR is failing in the build because we are deleting the package-lock.json in the GH action.
Since updating packages is not part of this PR, could you remove that line? (on top of that, I do not think we should be deleting the lock file in the build). That should fix the issue, will approve after that.
Thanks.

Are you referring to the process.exit() line?

No, I mean the line in the GH action that is referred to in the link above. So this one => https://github.com/vechainfoundation/hardhat-plugin-sample-ethers/blob/main/.github/workflows/common-unit-sonar.yml#L35

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants