Conversation
- Implemented a mock keyring for in-memory credential storage - Added feature flag `mock-keyring` to enable mock keyring functionality - Updated PIN retrieval to enforce a 30-character limit - Created integration tests for long PIN truncation behavior - Enhanced documentation on mock keyring usage and testing
- Replace legacy service name with constants for OTP storage - Update mock keyring implementation to use new service names - Ensure consistency in service name usage across keyring functions
- Updated version number in Cargo.toml for the main package - Updated version number in Cargo.toml for the akon-core package
- Allow quicker polling and quicker response times - Update regression tests to use new defaults - Update docs - Format code
- Cleaned up integration_keyring_tests by removing unnecessary imports.
vcwild
force-pushed
the
isolate-mock-keyring
branch
from
676645e to
4dc14e3
Compare
- Added helper function to store secrets in the system keyring - Updated tests to use system keyring for storing credentials - Cleaned up stored secrets after test execution
- Reorganized arguments in `store_system_secret` function for clarity - Improved formatting of command arguments in cleanup section - Adjusted import order for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes to the
akon-corecrate and its CI/testing infrastructure. The most notable changes are the introduction of a feature-gated mock keyring implementation for testing, updates to default reconnection policy parameters, and improvements to PIN handling and test coverage. These changes enhance testability, ensure consistent credential handling, and update documentation and configuration to reflect new defaults.Testing and CI improvements
.github/workflows/ci.ymlto run integration tests using themock-keyringfeature, enabling safe credential testing in CI environments.README.md.Mock keyring and credential handling
keyring.rsandkeyring_mock.rsto use shared service name constants (KEYRING_SERVICE_OTP,KEYRING_SERVICE_PIN) for credential storage and retrieval, removing legacy hardcoded service names. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] F95e4543L100R100)Reconnection policy defaults
max_attempts,consecutive_failures_threshold,health_check_interval_secs) in code, documentation, and test fixtures to reflect updated best practices. [1] [2] [3] [4] [5] [6] [7]Dependency and version management
1.2.1to1.2.2inCargo.tomlandakon-core/Cargo.toml. [1] [2]lazy_staticas an optional dependency gated by themock-keyringfeature, ensuring it is only included for testing and not in production builds.These changes collectively improve the reliability, security, and maintainability of credential management and reconnection logic in
akon-core, while making it easier to test and validate in CI and local environments.