threadtree: fix memory leak from thread ident reuse in pools#21
Open
kendriu wants to merge 1 commit intovast-data:vastfrom
Open
threadtree: fix memory leak from thread ident reuse in pools#21kendriu wants to merge 1 commit intovast-data:vastfrom
kendriu wants to merge 1 commit intovast-data:vastfrom
Conversation
the code was adding snapshots to the registry using thread.uuid as part of the key, then trying to remove them using thread.uuid again. when threadpoolexecutor reuses thread idents, thread.uuid can return a different value the second time because it looks up the uuid based on the thread's ident. this caused the cleanup to try removing a key that was never added, leaving the old entries in the registry forever. fix by capturing the uuid once and using that same value for both adding and removing
kendriu
force-pushed
the
memory_leak_2
branch
from
5c2da5d to
7555d3a
Compare
kendriu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the code was adding snapshots to the registry using thread.uuid
as part of the key, then trying to remove them using thread.uuid
again. when threadpoolexecutor reuses thread idents, thread.uuid
can return a different value the second time because it looks up
the uuid based on the thread's ident. this caused the cleanup to
try removing a key that was never added, leaving the old entries
in the registry forever. fix by capturing the uuid once and using
that same value for both adding and removing