refactor: remove flowFullstackSignals feature flag#2124
Open
Conversation
Signals support is now always enabled in Flow, so the feature flag check is no longer needed. This simplifies initSignalsSupport() and removes the now-unnecessary vaadin-featureflags.properties file.
Signals support is now always enabled in Flow, so the feature flag check is no longer needed. This simplifies initSignalsSupport() and removes the now-unnecessary vaadin-featureflags.properties file.
Test Results 138 files 138 suites 23m 19s ⏱️ For more details on these errors, see this check. Results for commit 76acb95. ♻️ This comment has been updated with latest results. |
mshabarov
reviewed
Feb 3, 2026
| .isEnabled(FeatureFlags.FLOW_FULLSTACK_SIGNALS.getId())) { | ||
| signalsTestEnvironment = TestSignalEnvironment.register(); | ||
| } | ||
| signalsTestEnvironment = TestSignalEnvironment.register(); |
Contributor
There was a problem hiding this comment.
This has been already merged to main, but the rest of the changes makes sense to add (javadocs, property file)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signals support is now always enabled in Flow, so the feature flag check is no longer needed. This simplifies initSignalsSupport() and removes the now-unnecessary vaadin-featureflags.properties file.