deprecate: mark first() and waitForFirst() for removal (#1729)#2117
Open
deprecate: mark first() and waitForFirst() for removal (#1729)#2117
Conversation
The first() method can lead to flaky tests when multiple matching elements exist, as it arbitrarily selects the first one without validation. Users should use single() instead, which asserts exactly one element matches and fails immediately if multiple are found, making tests more reliable and failures easier to diagnose. For intentional selection from multiple elements, get(int) or atIndex(int) should be used with an explicit index. Deprecated methods: - ElementQuery.first() - ElementQuery.waitForFirst() - ElementQuery.waitForFirst(long) - ComponentQuery.first() Fixes #1729
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1729