Redo Conditional Formatting for #461 originally in #701#715
Open
alvarezguille wants to merge 2 commits intomasterfrom
Open
Redo Conditional Formatting for #461 originally in #701#715alvarezguille wants to merge 2 commits intomasterfrom
alvarezguille wants to merge 2 commits intomasterfrom
Conversation
between POI updates and this new attempt at pushing my local conditional formatting work, I have much more properly supported. Now, cells where a conditional rule applies, and that rule has a number format different than the original cell format, display using the conditional format. Also addresses the list of issues identified in bug #461 and bug #651. Having this in Spreadsheet master means I can next send a PR for bug #529, adding support for table styles, both built-in and custom themed. The Excel official sample file showing how to use conditional formatting, which is included in the unit tests, now passes for more sheets. I see excellent equivalence except for: Features Spreadsheet doesn't support yet: * icon sets (sheet Quarters, Bike Rating, FY Months, Regional Sales) * data bars (Mountains) * gradients (Category Sales) Likely POI bugs in conditional formatting evaluation when rule formulas have relative cell references (I can reproduce the first few I tried in POI unit tests): * something goes wrong with styles on Compare to Totals * Syle not updating when values change to match conditional rules on Products3 * all rows show as matching on Customers2, instead of only unique rows. Could be a formula evaluation bug, or Conditional Formatting evaluation bug.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check #701 for details
This change is