fix for #651

[ianscriven]

see #651

Fixes the issue by reversing the iteration order when updating cells (so top to bottom, right to left).

---

This change is 

[WoozyG]

This is indeed the correct fix, but there are two places it is needed - two implementations of the batch processor functional interface in CellValueManager.

I have both plus a unit test based on the sample file in #651. I can commit them here or in branch feature/poi-3.17-update-to-release, which I think is close to being merged to master, pending resolution of one last test? For that matter this change may affect that test.

[ianscriven]

Hasn't that branch been merged as part of ed2822c? Or are there additional changes?

[WoozyG]

There are more changes pending, but a remaining unit test failure we haven't tracked down yet.

#640

[ianscriven]

Ok. I'm happy for this to be fixed in that branch, and it would make sense to do so if it will have an impact on unit tests.

[WoozyG]

I've committed the larger change (this one, plus reversing loop order on the other code path, plus this file as a unit test) to the other branch. Once the last unit test failure is resolved that should get merged back to master. At that point users could use future release builds with POI versions 3.17 through 4.0.x to pick up further formula evaluation bug fixes (there are two already in 4.0 master that affect some Vaadin unit tests).

[WoozyG]

I checked in the change, but something happened with the unit test run - all the PhantomJS screenshot comparison tests failed for some reason. Vaadin folks will have to tell us what happened there, TeamCity guest access doesn't have enough details.

[alvarezguille]

This is now addressed in #701, let's review and merge the solution based on latest POI