fix: update resources map on Spreadsheet client (#8437) (CP: 24.9) #8441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: update resources map on client Ensure that the resources map is updated with the new resource URI. When an image is moved away from the viewport, it can be detached and not available in the server anymore if the client side requests it again. Spreadsheet already reloads the image when it is scrolled back into view, but as it was using `setProperty` to set the `resources` property in the web component, it didn't trigger the update as Flow didn't detect a change in the property - the `resources` prop holds the name of the overlays and that indeed doesn't change, only the attribute value related to that resource. Changed by replacing `setProperty` with `executeJs` to ensure that Flow will trigger the update in the web component, thus updating the resource map so it will be used by the `img` element on creation. Fixes #8428
DiegoCardoso
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks changes from the original PR #8437 to branch 24.9.
Original PR description