fix: dev: added inequality method (fixes #26)#28
Closed
tommilligan wants to merge 1 commit intovaab:masterfrom
Closed
fix: dev: added inequality method (fixes #26)#28tommilligan wants to merge 1 commit intovaab:masterfrom
tommilligan wants to merge 1 commit intovaab:masterfrom
Conversation
1 similar comment
Author
|
Root cause was that the This PR:
|
Owner
|
Ok, many thanks. I'm in the process of reviewing your code and going into the #25 cases you've brought up. I have posted another PR #29, feel free to comment ! |
Owner
|
I pushed the other PR #29 that tackle the same issue a little differently. If anything is wrong with that, please voice your concern. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #26 where checking if two
Colorobjects were not equal (using!=) always returnedTrue.PR includes tests. I don't think additional changes to documentation are required.
This PR is based on the
masterbranch, as thedevbranch is currently failing build for Python 3.4.