fix: use NavigationLink for browser buttons in FeedDetailPage #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace sheet-based presentation with NavigationLink for the "使用浏览器打开" button to work around iOS 26 WKWebView blank screen bug. Changes: - Use NavigationLink instead of sheet for InAppBrowser and SafariView - Respect user's builtin browser preference setting - Remove unused showingSafari/showingMobileWeb state variables 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a WKWebView blank screen bug by replacing sheet-based presentation with NavigationLink for browser views in the FeedDetailPage. The changes respect user's builtin browser preference and upgrade from the simpler MobileWebView to the more feature-rich InAppBrowserView.
Key changes:
- Replace
.sheetmodifiers with hiddenNavigationLinkcomponents for InAppBrowserView and SafariView - Add
useBuiltinBrowsercomputed property to check user's browser preference from settings - Remove unused
showingSafari,safariURL,showingMobileWeb, andmobileWebURLstate variables
Code Coverage Report ❌Current coverage: 30.85% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
.sheetfor InAppBrowserView and SafariViewuseBuiltinBrowsercomputed property to check user preferenceshowingSafari/showingMobileWebstate variablesTest plan
🤖 Generated with Claude Code