Skip to content

Use locator's waitfor method #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
v-zhocai wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Use locator's waitfor method #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6107471
add waitfor on locator
v-zhocai Sep 2, 2025
97a1ebd
delete unused waitfor
v-zhocai Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/common/commonSteps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,16 +256,8 @@ async function installExtensionForCommand(page: Page, extensionDir: string) {
process.env.VSIX_PATH || path.resolve(__dirname, "../../extension.vsix")
await sleep(5)
await page.keyboard.press("Control+Backquote")
await page.getByRole("textbox", { name: /Terminal/ }).first().waitFor({ state: 'visible', timeout: 10000 })
await screenShot.screenShot("open_terminal.png")
await retry(
10,
async () => {
const cmd = page.getByRole("textbox", { name: /Terminal/ }).first()
return (await cmd.count()) > 0
},
"Failed to find command palette",
3
)
const cmd = page.getByRole("textbox", { name: /Terminal/ }).first()
await cmd.click()
await sleep(2)
Expand Down
6 changes: 0 additions & 6 deletions src/common/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,6 @@ const test = baseTest.extend<{
],
})
)
// spawn("code", [
// "--install-extension",
// path.resolve(__dirname, "../../extension.vsix"),
// "--extensions-dir",
// path.resolve(tempDir, "extensions"),
// ])
return { page, extensionDir: path.join(tempDir, "extensions") }
})

Expand Down