Implement filter by participation experiment tags #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- (QueryExperimentTags : Filter.Key.input_type) -> QueryTaggedExperiments - (ExperimentTag : Filter.Key.hardcoded) -> TaggedParticipation
reynir
force-pushed
the
feature/filter-experiment-tags
branch
from
d30d769 to
a1994a0
Compare
reynir
commented
Jan 15, 2026
| ; get "/create" ~middlewares:[ Access.create ] new_form | ||
| ; post "" ~middlewares:[ Access.create ] create | ||
| ; post "/search" ~middlewares:[ Access.search ] search | ||
| ; post "/search-experiment" ~middlewares:[ Access.search ] search_experiment_tags |
Collaborator
Author
There was a problem hiding this comment.
Here I had to add another endpoint so the htmx can find experiment tags. Alternatively, we can modify htmx_search_helper to look for a model parameter in the POST body, but it doesn't seem natural to add that to the existing implementation.
Collaborator
Author
|
@PossessedC0bra The PR is ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this as a draft as I'd like to review this myself again as there are a few things I'm unsure of. There is as well some duplication of code, and I add a new endpoint in the API which we can maybe avoid somehow.
I tested this manually by creating experiments with experiment tags and had participants. Then I created a new experiment to test the filter, and the results were as expected: only those who had previously participated in experiments with the selected tags were listed.
This addresses https://gitlab.uzh.ch/econ/study-coordination/pool/-/issues/2212.