Skip to content

Conversation

@mabiede
Copy link
Contributor

@mabiede mabiede commented Jul 2, 2025

No description provided.

@mabiede mabiede requested a review from Copilot July 2, 2025 05:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refreshes development environment settings and updates the OPAM lockfile to newer package versions.

  • Bump numerous OCaml package versions in guardian.opam.locked
  • Remove host SSH/Git mounts and switch sandbox mode in the Dev Container
  • Standardize ENV syntax in the Dockerfile

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
guardian.opam.locked Updated a wide range of package versions in the lockfile
.devcontainer/docker-compose.yml Removed SSH and Git config volume mounts
.devcontainer/devcontainer.json Changed OCaml sandbox kind from opam to global
.devcontainer/Dockerfile Switched ENV syntax to KEY=VALUE form
Comments suppressed due to low confidence (3)

.devcontainer/docker-compose.yml:13

  • By removing the SSH mount, contributors lose SSH access inside the container; consider adding documentation about alternative authentication methods or optional mounting instructions.
      - build:/workspace/_build:cached

.devcontainer/devcontainer.json:38

  • [nitpick] Switching the OCaml sandbox from opam to global changes dependency isolation behavior; update the README or add a comment explaining the new workflow for contributors.
          "kind": "global"

guardian.opam.locked:109

  • [nitpick] The & with-doc constraint was removed from the result package; if building documentation is required, consider re-adding it to ensure docs are generated.
  "result" {= "1.5"}

@mabiede mabiede merged commit 5c34866 into main Jul 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant