Merged
Conversation
Collaborator
|
This is great! I think it would best to follow the exact datafusion version. So that it is also |
Contributor
Author
|
Hi @Max-Meldrum, I updated the version. But I'm looking at the current CI failures and unsure if that's something I can fix in this PR. TL;DR is that Expr::Wildcard is now deprecated. So the logic has to be implemented differently. |
Collaborator
We can merge it and then fix it in another follow-up PR. Great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THis PR upgrades the project to support datafusion v46.
A question, should we bump the version number? And what should I bump it to?
from version = "40.0.0" ==> "41.0.0" ?