-
Notifications
You must be signed in to change notification settings - Fork 1
Memberof plugin #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
uubk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, I only have two small nitpicks.
| gid: 1000 | ||
| initialPassword: "{{ auth_kerberos_ldap_password }}" | ||
|
|
||
| auth_ldap_user_objectclasses: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment here that inetUser is added automatically when the memberOf overlay is enabled?
| --- | ||
|
|
||
| - name: Add inetUser to system users | ||
| set_fact: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're missing a when: auth_ldap_use_memberof_plugin here.
Fix missing condition to add the inetUser Document added objectclass
|
@uubk Ping :) |
|
@F1rst-Unicorn can we get this merged? :) |
|
@lukasreichart please note that I took action for each comment I received. So I think it can be merged |
|
@mxmo0rhuhn / @lukasreichart / @F1rst-Unicorn This one is on me - I have two LDAP related PRs open that I need to test, which is going to take about half a day and I didn't have the time yet. Trying to squeeze that it somewhen in July/August. |
|
@uubk is there anything we still need to do, to get this merged? |
|
@uubk any updates on this? |
Enable memberof plugin