Skip to content

Add project role #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hmacr wants to merge 4 commits into
base: 3.x
Choose a base branch
from
Open

Add project role #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e161e39
add project role
hmacr Nov 13, 2025
ad744de
add constraints
hmacr Nov 13, 2025
48cf606
Merge branch '3.x' into ser-541-3.x
hmacr Nov 26, 2025
b00fcf1
remove phpstan ignore-error directive
hmacr Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Database/Helpers/Role.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,4 +175,9 @@ public static function member(string $identifier): self
{
return new self('member', $identifier);
}

public static function project(string $identifier, string $dimension = ''): self
{
return new self('project', $identifier, $dimension);
}
}
14 changes: 12 additions & 2 deletions src/Database/Validator/Roles.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ class Roles extends Validator
public const ROLE_TEAM = 'team';
public const ROLE_MEMBER = 'member';
public const ROLE_LABEL = 'label';
public const ROLE_PROJECT = 'project';

public const ROLES = [
self::ROLE_ANY,
Expand All @@ -24,6 +25,7 @@ class Roles extends Validator
self::ROLE_TEAM,
self::ROLE_MEMBER,
self::ROLE_LABEL,
self::ROLE_PROJECT,
];

protected string $message = 'Roles Error';
Expand Down Expand Up @@ -108,6 +110,16 @@ class Roles extends Validator
'required' => false,
],
],
self::ROLE_PROJECT => [
'identifier' => [
'allowed' => true,
'required' => true,
],
'dimension' => [
'allowed' => true,
'required' => true,
],
]
];

// Dimensions
Expand Down Expand Up @@ -286,8 +298,6 @@ protected function isValidRole(
}

// Required and has no dimension
// PHPStan complains because there are currently no dimensions that are required, but there might be in future
// @phpstan-ignore-next-line
if ($allowed && $required && empty($dimension)) {
$this->message = 'Role "' . $role . '"' . ' must have a dimension value.';
return false;
Expand Down