updated string sizing code and test cases

[ArnabChatterjee20k]

if ($size > 16777215) {
return 'LONGTEXT';
}
if ($size > 65535) {
return 'MEDIUMTEXT';
}
if ($size > 16381) {
return 'TEXT';
}
return "VARCHAR({$size})";

To

if ($size > 767) {
return 'LONGTEXT';
}
return "VARCHAR({$size})";

Summary by CodeRabbit

• Bug Fixes

  • Simplified handling of large string attributes in MariaDB: strings over the maximum index length are stored as LONGTEXT, others as VARCHAR.
  • Adjusted maximum varchar length limit to dynamically reflect the maximum index length for consistency.

• Tests

  • Updated tests to expect LONGTEXT type and revised maximum length values for large string attributes.
  • Enhanced test coverage by dynamically generating multiple attributes to better simulate size limit conditions.

[coderabbitai]

Walkthrough

The changes simplify string type handling in the MariaDB adapter by removing intermediate TEXT and MEDIUMTEXT types, using only VARCHAR or LONGTEXT based on the maximum index length. The SQL adapter's getMaxVarcharLength() now returns a dynamic value from getMaxIndexLength(). Test assertions were updated to expect LONGTEXT and its maximum length. Additionally, some tests were modified to generate multiple attributes dynamically to better approach document size limits.

Changes

File(s)	Change Summary
src/Database/Adapter/MariaDB.php	Simplified getSQLType for strings: only VARCHAR or LONGTEXT based on max index length threshold.
src/Database/Adapter/SQL.php	getMaxVarcharLength() now returns dynamic getMaxIndexLength() instead of fixed 16381.
tests/e2e/Adapter/Scopes/CollectionTests.php	Updated test assertions to expect 'longtext' type and max length '4294967295' for 'story' attribute; replaced single large attribute with multiple smaller ones in test.
tests/e2e/Adapter/Scopes/AttributeTests.php	Modified testExceptionWidthLimit to create multiple attributes dynamically instead of fixed two attributes, to better approach document size limits.

Poem

A tweak to strings, a shift in size,
VARCHARs now are not so wide.
LONGTEXT leaps in when limits are met,
Old types retire, their sun has set.
Tests now dance with attributes anew—
More strings, more checks, a wider view!
🐇✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f31edfe and 8f19797.

📒 Files selected for processing (2)

• tests/e2e/Adapter/Scopes/AttributeTests.php (1 hunks)
• tests/e2e/Adapter/Scopes/CollectionTests.php (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• tests/e2e/Adapter/Scopes/CollectionTests.php

🔇 Additional comments (1)

tests/e2e/Adapter/Scopes/AttributeTests.php (1)

953-965: LGTM! Improved test design for document size limits.

The refactoring from fixed attributes to dynamic generation is well-implemented. The calculation correctly estimates how many 200-byte attributes can fit within the document size limit, accounting for UTF-8 encoding overhead. This approach provides better test coverage by systematically approaching the limit with multiple smaller attributes rather than relying on a few large ones.

The use of ID::unique() ensures proper unique identifiers for each generated attribute, and the loop structure is clean and efficient.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cc6538e and 41ad460.

📒 Files selected for processing (3)

• src/Database/Adapter/MariaDB.php (1 hunks)
• src/Database/Adapter/SQL.php (1 hunks)
• tests/e2e/Adapter/Scopes/CollectionTests.php (1 hunks)

🔇 Additional comments (2)

src/Database/Adapter/SQL.php (1)

1569-1571: Significant reduction in VARCHAR threshold - verify impact on existing systems.

The reduction from 16381 to 767 bytes is a substantial change that simplifies the string type logic as intended. However, this will cause strings that were previously stored as TEXT to now use LONGTEXT, which has different storage characteristics and performance implications.

Consider documenting this breaking change and its potential impact on:

• Storage overhead (LONGTEXT uses more metadata)
• Query performance (LONGTEXT is stored off-page)
• Existing schema migrations

tests/e2e/Adapter/Scopes/CollectionTests.php (1)

522-524: Test expectations correctly updated to reflect new sizing logic.

The test updates properly reflect the behavior change where the 'story' attribute (size 20000) now becomes 'longtext' instead of 'text' due to the reduced VARCHAR threshold of 767 bytes. The characterMaximumLength update to '4294967295' is also correct for LONGTEXT.