メッセージにホバーしたときに色が変わるようにし、右クリックでドロップダウンメニューを出せるようにした#3
Merged
aster-void merged 2 commits intomainfrom Aug 14, 2025
Merged
Conversation
aster-void
reviewed
Aug 13, 2025
Contributor
There was a problem hiding this comment.
JavaScript の命名規則はほとんどの場合スネークケース variable_name ではなくキャメルケース variableName なので、そのような名前にしてね。
aster-void
reviewed
Aug 13, 2025
Contributor
There was a problem hiding this comment.
ドロップダウンのメニューをこちら側で再実装するのではなく、 MessageList の方で #snippet を使って作ってやると onclick_ボタン名 みたいなのをボタンごとに渡さなくてもよくなりそう
そうすると MessageDropdown が複数 HTML に出てくることになるので、 visibility: hidden ではなく {#if visible}...{/if} で表示を操作してやると、やりたいことができると思う
Contributor
There was a problem hiding this comment.
例
<!-- MessageDropdown.svelte -->
<script lang="ts">
import type { Snippet } from "svelte";
const {
x,
y,
visible,
children,
}: { children: Snippet; x: number; y: number; visible: boolean } = $props();
</script>
{#if visible}
<div
style={`top: ${y}px; left: ${x}px; visibility: ${visible ? "visible" : "hidden"}`}
class="fixed"
>
{@render children()}
</div>
{/if}<!-- MessageList.svelte (抜粋) -->
<script lang="ts">
// 適切なタイミングで変更するハンドラを入れる
let dropdownVisibleOn = $state<Id<"messages"> | null>(null);
</script>
{#each messages as message (message._id)}
<MessageDropdown visible={dropdownVisibleOn === message._id}>
{@render dropdownContent()}
</MessageDropdown>
{#snippet dropdownContent()}
<ul>...</ul>
{/snippet}
{/each}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.