Closed
Conversation
aster-void
reviewed
Nov 20, 2025
Deploying life-code with
|
| Latest commit: |
b833410
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://37fd2a6c.life-code.pages.dev |
| Branch Preview URL: | https://scoretemplate.life-code.pages.dev |
aster-void
reviewed
Nov 20, 2025
src/routes/+page.svelte
Outdated
| const sentence = event.data.data as showToastEvent; | ||
| toast.show(isJapanese ? sentence.japanese : sentence.english, "info"); | ||
| timer = "stopped"; | ||
| isProgress = false; |
Contributor
There was a problem hiding this comment.
トーストを表示したときにタイマーを止める必要はなさそう
(それはそれとして、 timer と is Progress ってどう違うんだ？)
Contributor
Author
There was a problem hiding this comment.
ループやすべて白マスのような状態に陥っても、自動で止まらずひたすら表示してしまうのですが、新しくjsファイル側から再生、停止を変えられるように変更したほうがいいですか？
Contributor
There was a problem hiding this comment.
JSの方で呼び出すときに showToast とは別に再生停止するのがいいんじゃない？トーストとそれらの動作は別物だと思う
aster-void
reviewed
Nov 21, 2025
| }; | ||
|
|
||
| function showToast(jMessage, eMessage) { | ||
| timer = "stop"; |
Contributor
There was a problem hiding this comment.
ここでタイマーを止めるのは showToast という名前から連想される動作ではなさそう
Contributor
There was a problem hiding this comment.
というかそもそも life game の中でタイマーの進行状況を管理する必要がないかも？
Contributor
Author
There was a problem hiding this comment.
再生中は、盤面をなぞっても色を変更しないようにするために使っていますが…
再生中でも色は変更できた方がいいですかね？
Contributor
There was a problem hiding this comment.
再生中に色を変更できないのはなんでだっけ？
Contributor
There was a problem hiding this comment.
コンフリクトになってしまい、すみません。
+page.svelteに関しては、
- ”sync”イベントは"get_boardsize"イベントに名称を変更
- "play", "pause"イベント(おそらく、再生中に色が変更できないようにする機能しかない)は削除
- timerをtimerIsRunnning(boolean)に変更
- ルール選択ボタンを移動
という変更点がmainブランチに加えられました
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
スコアは増加した生きたセルの数（減少時は変化なし）が加算されます