Merged
Conversation
Deploying life-code with
|
| Latest commit: |
f16c913
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e5c5b2db.life-code.pages.dev |
| Branch Preview URL: | https://uidesign-v5.life-code.pages.dev |
aster-void
reviewed
Nov 17, 2025
src/iframe/life-game.js
Outdated
| } | ||
| rerender(); | ||
| generationChange(0); | ||
| // generationChange(0); 別に世代をリセットする必要はない？ |
Contributor
There was a problem hiding this comment.
必要がなかったら消してね (ユーザーに直接表示される部分なので)
Contributor
Author
There was a problem hiding this comment.
ミーティングで束原さんに確認したら対処します！
aster-void
reviewed
Nov 17, 2025
| }} | ||
| > | ||
| <img class="size-6" src={icons.questionmark} alt="Info" /> | ||
| </button> |
Contributor
There was a problem hiding this comment.
実装が間に合わなかった時に謎の ? マークが残ることになるので、実際に実装するまではコメントアウトしておくのが良さそう
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
・ボードをiframeの中央に配置
・テンプレート配置時の世代リセットを削除
・toastを最前面に配置
・世代の初期値を0に統一
・チュートリアル・ヘルプ表示用ボタン(空)を配置