-
Notifications
You must be signed in to change notification settings - Fork 1
UIdesign v3 #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
UIdesign v3 #16
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
edc9379
separate generation from iframe
kg0816 ed2eca2
separate reset random button
kg0816 53623cc
separate boardsize
kg0816 596ca83
small fix
kg0816 10bb539
Merge branch 'main' of https://github.com/ut-code/life-code into UIde…
kg0816 05d2789
small fix
kg0816 c61aea4
pause fix
kg0816 3858e51
min/max size separate
kg0816 38a99b8
small fix
kg0816 eadcfce
reload bug fix
kg0816 bb6cb98
Merge remote-tracking branch 'origin/main' into UIdesign_v3
kg0816 371cc24
Merge branch 'main' into UIdesign_v3
Haruto-Imai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,22 @@ | ||
| <html lang="ja"> | ||
| <html lang="ja" style="height: 90%"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <title>Title</title> | ||
| </head> | ||
| <body> | ||
| <h1> | ||
| <div id="generation">第0世代</div> | ||
| </h1> | ||
| ボードのサイズ<span id="sizeLabel"></span>: | ||
| <input type="number" id="sizeInput" style="width: 50px" /> | ||
| <button id="sizeChangeButton">サイズ変更</button> | ||
|
|
||
| <body | ||
| style=" | ||
| height: 100%; | ||
| display: flex; | ||
| align-items: flex-start; | ||
| justify-content: center; | ||
| padding-top: 10px; | ||
| " | ||
| > | ||
| <table id="game-board" style="border-collapse: collapse"></table> | ||
| <button id="randombutton">RANDOM</button> | ||
| <button id="resetbutton">RESET</button> | ||
|
|
||
| <button id="saveButton">SAVE</button> | ||
| <button id="loadButton">LOAD</button> | ||
| <div id="pattern-button-container"></div> | ||
|
|
||
| <script src="./life-game.js"></script> | ||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これしようとすると大変になってくるので、外側で世代とかの情報を管理して、「世代交代」だけを iframe に渡すのがいいんじゃないかな。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intervalの間隔は編集可能にしておきたいのでその辺のコードは外に置きたくないってのがあります。
この先似たようなのが増えるわけではない(はず)なので複雑さもそこまでひどくならないとは思いますが...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interval ってこっちで編集機能を用意しておくんじゃなかったっけ?
それならそれでもいいと思う