Skip to content

Improve handling of ignored modules in renaming #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
toinehartman wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Improve handling of ignored modules in renaming #626

toinehartman wants to merge 8 commits into from

Conversation

@toinehartman
Copy link
Member

@toinehartman toinehartman commented Apr 23, 2025 •
edited
Loading

Properly support ignored modules in renaming.

Discovered in #588 and was blocked by usethesource/rascal#2513 for a while.

@toinehartman toinehartman added the bug Something isn't working label Apr 23, 2025
@toinehartman toinehartman self-assigned this Apr 23, 2025
@DavyLandman
Copy link
Member

DavyLandman commented Apr 23, 2025

Hmm, I thought the @ignoreCompiler is only about test execution? Right @PaulKlint ?

@toinehartman
Copy link
Member Author

toinehartman commented Apr 23, 2025

Hmm, I thought the @ignoreCompiler is only about test execution?

Currently, the compiler does not produce a TModel for @ignoredCompiler-annotated modules. getTModelForModule returns false and the module status contains ignored().

Btw, this PR currently fails with a run-time error w.r.t. ignored(). Already informed @PaulKlint about this; he would look into it.

@toinehartman toinehartman force-pushed the fix/rename-refactoring/ignored-modules branch from 80fac65 to 9353c51 Compare July 10, 2025 13:47
@toinehartman toinehartman force-pushed the fix/rename-refactoring/ignored-modules branch from 9353c51 to a04d8e7 Compare September 1, 2025 11:55
@toinehartman toinehartman force-pushed the fix/rename-refactoring/ignored-modules branch from a04d8e7 to 9bd9f05 Compare September 15, 2025 11:36
@toinehartman toinehartman force-pushed the fix/rename-refactoring/ignored-modules branch from 9f929ba to 1f91cb4 Compare November 4, 2025 16:21
@toinehartman toinehartman force-pushed the fix/rename-refactoring/ignored-modules branch from cb0be92 to 3963bb7 Compare January 29, 2026 15:56
@toinehartman toinehartman changed the title [Rename] Improve handling of ignored modules. Improve handling of ignored modules in renaming Jan 30, 2026
@toinehartman toinehartman marked this pull request as ready for review January 30, 2026 14:00
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 30, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@toinehartman toinehartman

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@toinehartman @DavyLandman