Mitchellkwong/clashing bookings #250
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellkwong
force-pushed
the
mitchellkwong/clashing-bookings
branch
from
ccd0254 to
a724798
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The method previously used to compare bookings is not inclusive (i.e. 5pm and 5pm don't count as overlapping) and allows for double booking if the start and end times are exactly the same.
Resolved by adding another condition to reject the event if both start and end times are the same.
How to test this change
Tested on local development server. A clashing booking was correctly rejected by the events booking page.
Checklists
Checklist for developer of feature
Checklist for reviewers