Conversation
added 30 commits
October 14, 2024 16:02
fix(repo): clarify code comments feat(repo): add docbblocks to methods
…ponse types and custom deserializer
…ss and failure cases fix(repo): fix blockUrls to be arr
refactor(repo): update urlboxoptions types refactor(repo): split classes into their own files
…er method refactor(repo): make global usings and organise resources and policies into dirs
…test refactor(readme): update readme with new usage examples including new methods refactor(repo): update readme with static fromcredentials example, fix test warnings
refactor(repo): move urlboxoptions tests to own file
… resource tests and test for deserializer in render()
chore(repo): remove unused imports add test to urlboxoptions fix(repo): seal urlbox class make urlbox values readonly private, remove unused webhookSecret which only gets consumed in UrlboxWebhookValidator Implement getUrlboxErrorMessage, which extracts from err message in headers chore(tests): cleanup tests chore(repo): place classes into file namespaces refactor(repo): implement abstract urlbox response
chore(repo): capitalise verifywebhooksignature method chore(repo): reorder methods into categories with public/private
… for singleton/request/transient
…e and takefullpage feat(repo): update the readme WIP feat(repo): update readme
fix(repo): add webhookUrl to tests chore(repo): add note on DI in readme refactor(repo): verifyWebhookSignature returns the full reponse object as a type instead of bool chore(repo): move resources into their own dirs
refactor(repo): update readme to include usage of the urlbox options builder
chore(repo): add changelog t TOC refactor(repo): proof read repo fix(repo): add gh image not showing in repo variant of readme chore(repo): remove old xunit tests fix(readme): replace occurrences of screenshotting with rendering fix(readme): add explanation for getting project keys with screenshot
chore(repo): rename GenerateUrlboxUrl() to GenerateRenderLink() fix(readme): update comments in JSON to use # chore(repo): rename GenerateUrlboxUrl() to GenerateRenderLink() fix(readme): update s3 comment, replace lowercased .render with .Render
…please-test chore(release-please-test): release 1.2.0
…please-test chore(release-please-test): release 1.3.0
…please-test chore(release-please-test): release 1.4.0
…please-test chore(release-please-test): release 1.5.0
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…dd in nuget pub step
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.