Fix memleak in Lick on exit, annotate static lifetimes for LSAN #933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Related: does |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #932 I decided to take a closer look on memory leak reports on exit from vere, which were previously shrugged off as false positives on objects that have static lifetimes.
I found that
_lick_io_exitforgets to free the path to IPC directory before freeing the struct itself. I also decided to explicitly annotate objects that supposedly have static lifetimes, so that LSAN printouts on exit have less noise.To review: do the objects annotated with
__lsan_ignore_objectactually have static lifetimes?