This repository was archived by the owner on May 12, 2023. It is now read-only.
Homework3 #82
Open
Homework3 #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Son commit payments app için olan kısımlarla birlikte baya bir kalabalık oldu. Pull requesti nasıl geri çekeceğimi bilemedim |
upy
suggested changes
Dec 11, 2021
| @@ -1,5 +1,5 @@ | |||
| SECRET_KEY=g)8v11ythdn-p_^4+@z23_1&x=qzp^(-#py*8v$&4bnjb&=$a% | |||
Owner
There was a problem hiding this comment.
bu dosyaya gerce bilgileri eklememeliyiz.
ecommerce/baskets/serializers.py
Outdated
| @atomic() | ||
| def create(self, validated_data): | ||
| basket = validated_data.pop("basket", None) | ||
| basket_item = super().create(validated_data) |
Owner
There was a problem hiding this comment.
basket olmadan basket item olusturamayiz, ayrica detailed serializerlari genelde sadece veri gosterimi icin kullaniyoruz.
ecommerce/baskets/serializers.py
Outdated
| serializer = CustomerSerializer(data=customer, many=False) | ||
| serializer.is_valid(raise_exception=True) | ||
| serializer.save() | ||
| basket.customer.add(*serializer.instance) |
Owner
There was a problem hiding this comment.
customer burada none degerine sahip bunun add seklinde bir attribute'u olmadigini soyleyecektir.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEWORK 3
Filters, Serializers, Viewsets